Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Fix inefficiency in getBridgelessNetworks ......................................................................
Fix inefficiency in getBridgelessNetworks
This commit makes getBridgelessNetworks use the Netinfo instance networks instead of generating its own. Additionally, it is put in the style and vicinity of the most semantically similar method of the class, to improve the module's readability.
Change-Id: I68b5ecf415d4ab49a56019d8875dde57ca29d1fc Signed-off-by: Antoni S. Puimedon asegurap@redhat.com --- M vdsm/netinfo.py 1 file changed, 11 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/11071/1
diff --git a/vdsm/netinfo.py b/vdsm/netinfo.py index 4749708..43a2781 100644 --- a/vdsm/netinfo.py +++ b/vdsm/netinfo.py @@ -439,6 +439,17 @@ return chain(self.getBridgelessNetworksForIface(iface), self.getBridgedNetworksForIface(iface))
+ def getBridgelessNetworks(self): + """ + Get list of bridgeless networks + + :returns: list of network names + :rtype: List + """ + for network, netdict in self.networks.iteritems(): + if not netdict['bridged']: + yield network + def getBridgelessNetworksForIface(self, iface): """ Return all bridgeless networks attached to nic/bond """ for network, netdict in self.networks.iteritems(): @@ -494,13 +505,3 @@ lnics.append(port)
return lnics, vlan, bonding - - def getBridgelessNetworks(self): - """ - Get list of birdgeless networks - - :returns: list of networks name - :rtype: List - """ - return [netname for (netname, net) in networks().iteritems() - if not 'bridge' in net]
-- To view, visit http://gerrit.ovirt.org/11071 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I68b5ecf415d4ab49a56019d8875dde57ca29d1fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix inefficiency in getBridgelessNetworks ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/774/ (1/2)
-- To view, visit http://gerrit.ovirt.org/11071 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68b5ecf415d4ab49a56019d8875dde57ca29d1fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix inefficiency in getBridgelessNetworks ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/739/ (2/2)
-- To view, visit http://gerrit.ovirt.org/11071 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68b5ecf415d4ab49a56019d8875dde57ca29d1fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix inefficiency in getBridgelessNetworks ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/739/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/774/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/11071 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68b5ecf415d4ab49a56019d8875dde57ca29d1fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has posted comments on this change.
Change subject: Fix inefficiency in getBridgelessNetworks ......................................................................
Patch Set 1: (1 inline comment)
It looks good to me except the function's docstring.
.................................................... File vdsm/netinfo.py Line 444: Get list of bridgeless networks Line 445: Line 446: :returns: list of network names Line 447: :rtype: List Line 448: """ The docstring should be updated accordingly. Line 449: for network, netdict in self.networks.iteritems(): Line 450: if not netdict['bridged']: Line 451: yield network Line 452:
-- To view, visit http://gerrit.ovirt.org/11071 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68b5ecf415d4ab49a56019d8875dde57ca29d1fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has posted comments on this change.
Change subject: Fix inefficiency in getBridgelessNetworks ......................................................................
Patch Set 1: I would prefer that you didn't submit this
-- To view, visit http://gerrit.ovirt.org/11071 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68b5ecf415d4ab49a56019d8875dde57ca29d1fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix inefficiency in getBridgelessNetworks ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/740/ (2/2)
-- To view, visit http://gerrit.ovirt.org/11071 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68b5ecf415d4ab49a56019d8875dde57ca29d1fc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix inefficiency in getBridgelessNetworks ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/775/ (1/2)
-- To view, visit http://gerrit.ovirt.org/11071 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68b5ecf415d4ab49a56019d8875dde57ca29d1fc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix inefficiency in getBridgelessNetworks ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/740/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/775/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/11071 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68b5ecf415d4ab49a56019d8875dde57ca29d1fc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has posted comments on this change.
Change subject: Fix inefficiency in getBridgelessNetworks ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/11071 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68b5ecf415d4ab49a56019d8875dde57ca29d1fc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Fix inefficiency in getBridgelessNetworks ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/11071 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68b5ecf415d4ab49a56019d8875dde57ca29d1fc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix inefficiency in getBridgelessNetworks ......................................................................
Fix inefficiency in getBridgelessNetworks
This commit makes getBridgelessNetworks use the Netinfo instance networks instead of generating its own. Additionally, it is put in the style and vicinity of the most semantically similar method of the class, to improve the module's readability.
Change-Id: I68b5ecf415d4ab49a56019d8875dde57ca29d1fc Signed-off-by: Antoni S. Puimedon asegurap@redhat.com --- M vdsm/netinfo.py 1 file changed, 6 insertions(+), 10 deletions(-)
Approvals: Mark Wu: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/11071 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I68b5ecf415d4ab49a56019d8875dde57ca29d1fc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Fix inefficiency in getBridgelessNetworks ......................................................................
Patch Set 2: Verified
No one is using getBridgelessNetworks(), so I can say that it's verified.
-- To view, visit http://gerrit.ovirt.org/11071 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68b5ecf415d4ab49a56019d8875dde57ca29d1fc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org