Hello Douglas Schilling Landgraf, Dan Kenigsberg,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: Searching for both py and pyc file to start super vdsm ......................................................................
Searching for both py and pyc file to start super vdsm
In oVirt Node we don't keep py files.
Change-Id: I36771ce46f5d00ad8befe33569252bdb8cffeaa1 Signed-off-by: Yaniv Bronhaim ybronhei@redhat.com Reviewed-on: http://gerrit.ovirt.org/10854 Reviewed-by: Douglas Schilling Landgraf dougsland@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M vdsm/supervdsm.py 1 file changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/11133/1
diff --git a/vdsm/supervdsm.py b/vdsm/supervdsm.py index 532d5ac..740a93e 100644 --- a/vdsm/supervdsm.py +++ b/vdsm/supervdsm.py @@ -35,19 +35,23 @@ _g_singletonSupervdsmInstance_lock = threading.Lock()
-def __supervdsmServerPath(serverFile): +def __supervdsmServerPath(): base = os.path.dirname(__file__)
- serverPath = os.path.join(base, serverFile) - if os.path.exists(serverPath): - return os.path.abspath(serverPath) + # serverFile can be both the py or pyc file. In oVirt node we don't keep + # py files. this method looks for one of the two to calculate the absolute + # path of supervdsmServer + for serverFile in ("supervdsmServer.py", "supervdsmServer.pyc"): + serverPath = os.path.join(base, serverFile) + if os.path.exists(serverPath): + return os.path.abspath(serverPath)
raise RuntimeError("SuperVDSM Server not found")
PIDFILE = os.path.join(constants.P_VDSM_RUN, "svdsm.pid") TIMESTAMP = os.path.join(constants.P_VDSM_RUN, "svdsm.time") ADDRESS = os.path.join(constants.P_VDSM_RUN, "svdsm.sock") -SUPERVDSM = __supervdsmServerPath("supervdsmServer.py") +SUPERVDSM = __supervdsmServerPath()
extraPythonPathList = []
-- To view, visit http://gerrit.ovirt.org/11133 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I36771ce46f5d00ad8befe33569252bdb8cffeaa1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.2 Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Vinzenz Feenstra has posted comments on this change.
Change subject: Searching for both py and pyc file to start super vdsm ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/11133 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I36771ce46f5d00ad8befe33569252bdb8cffeaa1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.2 Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com
Yaniv Bronhaim has posted comments on this change.
Change subject: Searching for both py and pyc file to start super vdsm ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/11133 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I36771ce46f5d00ad8befe33569252bdb8cffeaa1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.2 Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Searching for both py and pyc file to start super vdsm ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/11133 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I36771ce46f5d00ad8befe33569252bdb8cffeaa1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.2 Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Searching for both py and pyc file to start super vdsm ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/11133 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I36771ce46f5d00ad8befe33569252bdb8cffeaa1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.2 Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Searching for both py and pyc file to start super vdsm ......................................................................
Searching for both py and pyc file to start super vdsm
In oVirt Node we don't keep py files.
Change-Id: I36771ce46f5d00ad8befe33569252bdb8cffeaa1 Signed-off-by: Yaniv Bronhaim ybronhei@redhat.com Reviewed-on: http://gerrit.ovirt.org/10854 Reviewed-by: Douglas Schilling Landgraf dougsland@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M vdsm/supervdsm.py 1 file changed, 9 insertions(+), 5 deletions(-)
Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Vinzenz Feenstra: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/11133 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I36771ce46f5d00ad8befe33569252bdb8cffeaa1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.2 Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com
vdsm-patches@lists.fedorahosted.org