Nigel Jones has uploaded a new change for review.
Change subject: BZ#824729 - Use doubler param in _loadCorrectedTimeout ......................................................................
BZ#824729 - Use doubler param in _loadCorrectedTimeout
Vm._loadCorrectedTimeout does not use the doubler parameter as defined in the function documentation which causes issues when a large number of migrations are used and a doubler value of 5 is expected to be used, instead of the hard-coded value of 20.
Change-Id: I83678b27411e3d582fb36858d79aba9dc4c15ac6 Signed-off-by: Nigel Jones nigjones@redhat.com --- M vdsm/vm.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/4728/1 -- To view, visit http://gerrit.ovirt.org/4728 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I83678b27411e3d582fb36858d79aba9dc4c15ac6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nigel Jones nigjones@redhat.com
Lee Yarwood has posted comments on this change.
Change subject: BZ#824729 - Use doubler param in _loadCorrectedTimeout ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4728 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I83678b27411e3d582fb36858d79aba9dc4c15ac6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nigel Jones nigjones@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#824729 - Use doubler param in _loadCorrectedTimeout ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
clearly, this was the original author's intention. but such a change requires a serious verification on a loaded setup.
-- To view, visit http://gerrit.ovirt.org/4728 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I83678b27411e3d582fb36858d79aba9dc4c15ac6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nigel Jones nigjones@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com
Peter V. Saveliev has posted comments on this change.
Change subject: BZ#824729 - Use doubler param in _loadCorrectedTimeout ......................................................................
Patch Set 1: Verified; Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4728 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I83678b27411e3d582fb36858d79aba9dc4c15ac6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nigel Jones nigjones@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com
Peter V. Saveliev has posted comments on this change.
Change subject: BZ#824729 - Use doubler param in _loadCorrectedTimeout ......................................................................
Patch Set 1: No score
-- To view, visit http://gerrit.ovirt.org/4728 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I83678b27411e3d582fb36858d79aba9dc4c15ac6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nigel Jones nigjones@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#824729 - Use doubler param in _loadCorrectedTimeout ......................................................................
BZ#824729 - Use doubler param in _loadCorrectedTimeout
Vm._loadCorrectedTimeout does not use the doubler parameter as defined in the function documentation which causes issues when a large number of migrations are used and a doubler value of 5 is expected to be used, instead of the hard-coded value of 20.
Change-Id: I83678b27411e3d582fb36858d79aba9dc4c15ac6 Signed-off-by: Nigel Jones nigjones@redhat.com --- M vdsm/vm.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Lee Yarwood: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved Peter V. Saveliev: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4728 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I83678b27411e3d582fb36858d79aba9dc4c15ac6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nigel Jones nigjones@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#824729 - Use doubler param in _loadCorrectedTimeout ......................................................................
Patch Set 1: Verified; Looks good to me, approved
Let us push it as-is. If it causes regressions in some setup, it should be fixed by changing doubler=5 in libvirtvm.py.
-- To view, visit http://gerrit.ovirt.org/4728 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I83678b27411e3d582fb36858d79aba9dc4c15ac6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nigel Jones nigjones@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com
vdsm-patches@lists.fedorahosted.org