Federico Simoncelli has uploaded a new change for review.
Change subject: Add syncImage to copy an image subchain ......................................................................
Add syncImage to copy an image subchain
Change-Id: I9ec8ec97536099f4f73b7d9a72956c873908d04d --- M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/storage/hsm.py M vdsm/storage/sp.py 4 files changed, 71 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/3218/1 -- To view, visit http://gerrit.ovirt.org/3218 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I9ec8ec97536099f4f73b7d9a72956c873908d04d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Add syncImage to copy an image subchain ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
The only thing I'm really disapproving is the empty fixme
.................................................... File vdsm/storage/hsm.py Line 1327: volUUID)) It's nothing personal against you or this patch in particular but a general gripe I have against the this "pattern" in general.
This entire habit of mashing all the args to the generic exception is pretty redundant and wasteful IMO. The args are already logged on the method entrances through the @public decorator anyway.
Also the thing I don't get about setDefaultException() is what is so wrong about just doing try\except. Is it just too mainstream for us?
Line 1339: self.validateSdUUID(dstDomUUID) I just hope Edu doesn't see you validating here :)
.................................................... File vdsm/storage/sp.py Line 1682: # FIXME: FIXME?
-- To view, visit http://gerrit.ovirt.org/3218 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9ec8ec97536099f4f73b7d9a72956c873908d04d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has abandoned this change.
Change subject: [WIP] Initial live storage migration implementation ......................................................................
Patch Set 2: Abandoned
Moved to: http://gerrit.ovirt.org/#/c/5252/
-- To view, visit http://gerrit.ovirt.org/3218 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I9ec8ec97536099f4f73b7d9a72956c873908d04d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org