Nir Soffer has uploaded a new change for review.
Change subject: utils: Add missing Popen methods ......................................................................
utils: Add missing Popen methods
AsyncProc should have a Popen like interface, but it is missing terminate() and send_signal() methods. These methods are useful for testing and for implementing graceful termination.
Change-Id: I5d562663698d86b98b55d139e2691a0f51566ccf Signed-off-by: Nir Soffer nsoffer@redhat.com --- M lib/vdsm/commands.py 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/65321/1
diff --git a/lib/vdsm/commands.py b/lib/vdsm/commands.py index 9245a8b..f694788 100644 --- a/lib/vdsm/commands.py +++ b/lib/vdsm/commands.py @@ -297,6 +297,12 @@ def poll(self): return self.returncode
+ def send_signal(self, signo): + self._proc.send_signal(signo) + + def terminate(self): + self._proc.terminate() + def kill(self): try: self._proc.kill()
gerrit-hooks has posted comments on this change.
Change subject: utils: Add missing Popen methods ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Nir Soffer has posted comments on this change.
Change subject: utils: Add missing Popen methods ......................................................................
Patch Set 1: Verified+1
Verified by the tests.
gerrit-hooks has posted comments on this change.
Change subject: utils: Add missing Popen methods ......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: utils: Add missing Popen methods ......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Nir Soffer has posted comments on this change.
Change subject: utils: Add missing Popen methods ......................................................................
Patch Set 3: Continuous-Integration+1
Verfied on travis: https://travis-ci.org/nirs/vdsm/builds/166549485
Francesco Romani has posted comments on this change.
Change subject: utils: Add missing Popen methods ......................................................................
Patch Set 3: Code-Review+1
gerrit-hooks has posted comments on this change.
Change subject: utils: Add missing Popen methods ......................................................................
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Piotr Kliczewski has posted comments on this change.
Change subject: utils: Add missing Popen methods ......................................................................
Patch Set 4: Code-Review+1
gerrit-hooks has posted comments on this change.
Change subject: utils: Add missing Popen methods ......................................................................
Patch Set 5:
* Update Tracker::IGNORE, not relevant for branch: master * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Add missing Popen methods ......................................................................
Patch Set 5:
raising
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Add missing Popen methods ......................................................................
Patch Set 5: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Add missing Popen methods ......................................................................
utils: Add missing Popen methods
AsyncProc should have a Popen like interface, but it is missing terminate() and send_signal() methods. These methods are useful for testing and for implementing graceful termination.
Change-Id: I5d562663698d86b98b55d139e2691a0f51566ccf Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/65321 Reviewed-by: Francesco Romani fromani@redhat.com Reviewed-by: Piotr Kliczewski piotr.kliczewski@gmail.com Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg danken@redhat.com --- M lib/vdsm/commands.py 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve
gerrit-hooks has posted comments on this change.
Change subject: utils: Add missing Popen methods ......................................................................
Patch Set 6:
* Update Tracker::IGNORE, no bug url/s found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org