Igor Lvovsky has posted comments on this change.
Change subject: BZ#744755 Don't wait for tasks on shutdown [EXTRA]
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 1315: def startRepoStats(self, sdUUID):
Line 1316: statthread = self.repostats.get(sdUUID)
Line 1317: if not statthread:
Line 1318: statthread = StatsThread(self._repostats, sdUUID)
Line 1319: statthread.daemon = True
Did you set it in _init_ ? Why again?
Line 1320: statthread.start()
Line 1321: self.repostats[sdUUID] = statthread
Line 1322: self.log.debug("%s stat %s", sdUUID, statthread)
Line 1323:
--
To view, visit
http://gerrit.usersys.redhat.com/1049
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53cf150f3812cf13b2afbf47dab9fb9bd560fa33
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>