Eduardo Warszawski has posted comments on this change.
Change subject: BZ#722649 - Invalidate domain MD in removeStorageDomain()
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 1223: if len(dom.getPools()) > 0:
If the host is disconnected from the pool that contains this SD (or connected to another
pool) the master MD is not checked since getDomains is not called (or irrelevant)
If the host is connected to the pool there is no reason to assume that the result of
pool.getDomains (the master MD) is more actual than the result of sd.getPools (storage
domain MD). (*)
SD domain can be reached only as part of a pool, if the host was never connected to a pool
containing this SD, then there is no reason for this MD to be cached, and therefore is
nothing to invalidate.
If the host was connected to the pool before, then when it was disconnected from the pool,
the domain should be removed from the cache or invalidated, not here.(**)
If MD is valid, it should be up to date, and reflect that the domain is detached.
This change should address BZ#719330 too.
(*) Inconsistencies between pool (master) and SD domain metadata is another bug.
(**) autodetach is not in use by RHEV-M.
--
To view, visit
http://gerrit.usersys.redhat.com/728
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib436aa6b871014f87d2cd9929e7122d807f29ade
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>