Dan Kenigsberg has submitted this change and it was merged.
Change subject: Packaging: Fix help string and usage for --disable-libvirt-sanlock
......................................................................
Packaging: Fix help string and usage for --disable-libvirt-sanlock
Help strings in configure.ac for --disable-libvirt-sanlock and
--disable-libvirt-selinux are as follow.
--disable-libvirt-sanlock
disable libvirt sanlock plugin [default=yes]
--disable-libvirt-selinux
disable libvirt selinux plugin [default=yes]
From simplicity and disambiguation, we remove
"[default=yes]". This
patch changes the help string to as follow
--disable-libvirt-sanlock
disable libvirt sanlock plugin
--disable-libvirt-selinux
disable libvirt selinux plugin
So there is no ambiguity of whether the feature is disbale or enabled
by default. We also avoid suggesting user to use
"--disable-libvirt-sanlock=yes|no" which is a bit confusing (at least to
me). The user can just use "--disable-libvirt-sanlock" to disable it.
This patch also fix the code logic related to ENABLE_LIBVIRT_SELINUX in
libvirt_configure.sh.in to make it agree with the help string.
Change-Id: I935693a8b8e7c371c653853b9524c9a774bca6fd
Signed-off-by: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Reviewed-on:
http://gerrit.ovirt.org/19005
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M configure.ac
M lib/vdsm/tool/libvirt_configure.sh.in
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Zhou Zheng Sheng: Verified
--
To view, visit
http://gerrit.ovirt.org/19005
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I935693a8b8e7c371c653853b9524c9a774bca6fd
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server