Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-upgrade: use python scripts from ovirtnode ......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm_reg/vdsm-reg.conf.in Line 14: #The registrtion uri Line 15: vdc_reg_uri=/OvirtEngineWeb/register Line 16: #Upgrade settings Line 17: upgrade_iso_file=@VDSMUPGRADEDIR@/ovirt-node-image.iso Line 18: upgrade_mount_point=/live is this change intentional? it is undocumented. Line 19: # registration ticket
-- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Joey Boggs jboggs@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server