Dan Kenigsberg has posted comments on this change.
Change subject: BZ#845994 VM failed to start after file injection. ......................................................................
Patch Set 2: (3 inline comments)
.................................................... File vdsm_hooks/fileinject/before_vm_start.py Line 34: sys.stderr.write('fileinject: [error in inject_file]: %s\n' % e) why is this function swallowing so many exceptions, while its calling function has a global "except" of its own?
Line 46: try: I believe this "try" should come right after mount_options()
Line 50: gfs.upload(temp.name, filepath) why are we not using
gfs.write(filepath, content)
instead of creating the tempfile?
-- To view, visit http://gerrit.ovirt.org/6956 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibb705a7153b1d2662a1c113bbbb5c694c568cabd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com