Dan Kenigsberg has posted comments on this change.
Change subject: Support for QEMU cmdline hook ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm_hooks/qemucmdline/before_vm_start.py Line 43: For eg: qemu_cmdline='{"-cdrom":"<path/to/iso>", ...}' what about cmdline args that does not have a value (think "-S")? what about the order? In some cases it is significant! I think that a simple list is better suited to the task.
.................................................... File vdsm_hooks/qemucmdline/README Line 9: The os environ 'qemu_cmdline' points to a json dict having one trailing whitespace, here and elsewhere.
-- To view, visit http://gerrit.ovirt.org/6969 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I48477926d271bb9f6ae74f79de5d8c4d37b87caa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com