Itamar Heim has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1: No score
iirc, vdsm has code to detect bios enablement, regardless vmx flag. but if vmx flag is always visible even if VT is disabled in bios (and same check has been done for AMD for svm flag), then i think this patch is ok. but please verify both intel and amd with a *cold* boot of the system (bios change for VT does not take effect on a warm reboot).
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server