Yaniv Bronhaim has posted comments on this change.
Change subject: Handling svdsm exception in multipath opeartion ......................................................................
Patch Set 1:
I know that you're right and this workaround looks like ignoring svdsm failures, that in general is totally wrong.
But, calling to svdsm as part of hsm.__init__ sounds risky to me, since svdsm can throw exception (also inside the proxy function) and that exception cause failure in hsm initialization, which means vdsm can't function afterwards but still running..
Is this right handling? maybe we should kill vdsm if such exception is raised, it's better then let vdsm to continue..
Am I missing something?
-- To view, visit http://gerrit.ovirt.org/10508 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id56ab966f3a21f4ef9fac0ad05e4f00f25cc16b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server