Ayal Baron has posted comments on this change.
Change subject: Support the quiesce flag during a live snapshot ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
The only thing I'm not sure of retry after failure with quiesce. Can we getCaps from guestAgent to know whether this is at all supported and not even try if it is not? (not just if libvirt supports it, but if the guest supports it). I'd rather avoid the error in the log and the wasted time in case there is no guest agent support for this. In addition, if there is ga support, I'm not sure the correct behaviour is to retry without it (even though this is what I told Federico).
-- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com