Yaniv Bronhaim has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5 ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
second ...
https://gerrit.ovirt.org/#/c/47941/1/init/vdsmd_init_common.sh.in File init/vdsmd_init_common.sh.in:
Line 256: local ret=0 Line 257: if grep -q '^vdsm-4.10.' "${upgraded_ver_file}"; then Line 258: # We need to treat the upgrade from 4.10.x specifically Line 259: # by running manual configure command Line 260: "$VDSM_TOOL" configure --force we should remove that. we need to add the REQUIRED_FOR here Line 261: ret=$? Line 262: elif grep -q '^vdsm-4.16.' "${upgraded_ver_file}"; then Line 263: # We need to treat the upgrade from 4.16.x specifically Line 264: # by running manual multipath configure command
Line 261: ret=$? Line 262: elif grep -q '^vdsm-4.16.' "${upgraded_ver_file}"; then Line 263: # We need to treat the upgrade from 4.16.x specifically Line 264: # by running manual multipath configure command Line 265: "$VDSM_TOOL" configure --module multipath don't we want to configure all if we already do that? and then you can merge the conditions? Line 266: ret=$? Line 267: fi Line 268: [ "${ret}" -eq 0 ] && rm -f "${upgraded_ver_file}" Line 269: fi