Milan Zamazal has posted comments on this change.
Change subject: logging: Improve log level alignment
......................................................................
Patch Set 2:
(1 comment)
I like the change, let's just replace the reference in the commit message.
https://gerrit.ovirt.org/#/c/64217/2//COMMIT_MSG
Commit Message:
Line 9: Shorten WARNING to WARN and CRITICAL to CRIT to make log messages align
Line 10: nicer.
Line 11:
Line 12: Here is an example log:
Line 13:
https://paste.fedoraproject.org/431570/raw/
Let's not use references to temporary locations, the change can be illustrated right
here.
Line 14:
Line 15: Change-Id: Ia18649258f145f974fd4a8f7a96b5849c4a77938
--
To view, visit
https://gerrit.ovirt.org/64217
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia18649258f145f974fd4a8f7a96b5849c4a77938
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes