Dan Kenigsberg has posted comments on this change.
Change subject: vdsmd.init: remove validation to reload config ......................................................................
Patch Set 1:
I still do not quite understand the problem you are trying to solve. I see two:
1. upstart game is done on ovirt-node, were it is not needed 2. /etc/init/libvirt.conf is overwritten by a too-aggressive vdsm 3. weird behavior if no libvirt.conf is found
(1) should be solved by checking if we're running on ovirt-node. (2) is a price I'm willing to pay in order to keep libvirtd up after a crash (3) should be fixed by [[ -z "$packaged" ]] or something like that.
removal of the upstart dance is not something I'm willing to drop for these reasons.
-- To view, visit http://gerrit.ovirt.org/4479 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ea03070bf2849e10c74d7921eac9401e2768502 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com