Zhou Zheng Sheng has posted comments on this change.
Change subject: Make vdsm/define.py PEP8 clean ......................................................................
Patch Set 4: (1 inline comment)
pydiff report:
$ pydiff define*.py 3 difference(s) first file: defineo.py second file: define.py
((27, 'sparse creation failed'), (41, 'sparse creation faild'))
((28, 'Error creating the requested virtual machine'), (44, 'Error creating the requested VM'))
((33, 'Not enough free memory to create virtual machine'), (61, 'Not enough free memory to create VM'))
This means, while change "virtual machine" to "VM" may be acceptable, change "failed" to "faild" may be a misspelling.
.................................................... File vdsm/define.py Line 41: 'message': 'sparse creation faild'}}, faild or failed?
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com