Allon Mureinik has posted comments on this change.
Change subject: Move the SANLock SDM lease to a different offset ......................................................................
Patch Set 15: Looks good to me, but someone else must approve
(1 inline comment)
looks good, but please fix the comment.
.................................................... File vdsm/storage/safelease.py Line 35: grammer: "in order to being able to acquire both locks (eg: during the domain upgrade)" -> "in order to preserve the ability to acquire both locks (e.g.: during the domain upgrade)"
-- To view, visit http://gerrit.ovirt.org/3840 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I45db6790acffecfda006b513b784f8138605ad81 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com