Joey Boggs has posted comments on this change.
Change subject: vdsm-upgrade: use python scripts from ovirtnode ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm_reg/vdsm-upgrade Line 96: if os.path.exists("/usr/libexec/ovirt-config-boot"): ovirt-config-boot will eventually disappear after this patch is done, take this line out above
Line 96 is strMountPoint a random directory? install.ovirt_boot_setup() will assume the new image is always at /live. If there's a reason to not always expect that directory we will need to adjust in ovirt node
-- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Joey Boggs jboggs@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server