Adam Litke has posted comments on this change.
Change subject: yml: return type fixes for StoragePool.getInfo ......................................................................
Patch Set 2:
(2 comments)
-1 for visibility of comments.
https://gerrit.ovirt.org/#/c/59707/2/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml:
Line 5690: Attached: The domain is attached to a Storage Pool but is Line 5691: deactivated Line 5692: Unattached: The domain is not attached to a Storage Pool Line 5693: Unknown: The status of the Storage Domain is not known Line 5694: Does engine have two separate enums (one capitalized on one not)? Line 5695: StorageDomainStatusMap: &StorageDomainStatusMap Line 5696: added: '3.1' Line 5697: description: A mapping of Storage Domain statuses indexed by Storage Line 5698: Domain UUID.
Line 5739: datatype: int Line 5740: Line 5741: - description: Current Storage Domain status Line 5742: name: status Line 5743: type: *StorageStatus This is confusing. The commit message needs to have some information about when the capitalized statuses are used and when the lowercase ones are used. Line 5744: Line 5745: - description: Indicates the Storage Domain version Line 5746: name: version Line 5747: type: int