Dan Kenigsberg has posted comments on this change.
Change subject: Add a VDSM verb to change MOM policy ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/vdsmMOM.py Line 53: # Now MOM expects policy content not filename as input parameter I was not a huge fan of this new vdsm verb, but it would be much more useful if vdsm, just like MOM, accepts a string policy instead of a local filename.
There are many systems where it would be pretty difficult to log in a place this file; it would be much easier to maintain if Engine (or whomever controls multiple vdsms) can set the policy on all of its servers.
-- To view, visit http://gerrit.ovirt.org/5069 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com