Nir Soffer has posted comments on this change.
Change subject: json-rpc: Protocol detection ......................................................................
Patch Set 31:
(2 comments)
http://gerrit.ovirt.org/#/c/26300/31/lib/vdsm/sslUtils.py File lib/vdsm/sslUtils.py:
Line 77: # result = self.connection.peek(size) Line 78: # else: Line 79: # result = self.connection.read(size) Line 80: # return result Line 81: # recv = read
rebase/debug relic?
We should remove this commented code later. Line 82: Line 83: def __getattr__(self, name): Line 84: return getattr(self.connection, name) Line 85:
http://gerrit.ovirt.org/#/c/26300/31/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py:
Line 1131: self.xml_binding = xml_binding Line 1132: Line 1133: def detect(self, data): Line 1134: return (data.startswith("PUT /") or data.startswith("GET /") or Line 1135: data.startswith("POST /RPC2"))
I tested xmlrpc by running CI dev job with the latest engine. I tested it o
What do you mean by "there is a / context"? Line 1136: Line 1137: def handleSocket(self, client_socket, socket_address): Line 1138: self.xml_binding.add_socket(client_socket, socket_address)