Dan Kenigsberg has posted comments on this change.
Change subject: sampling: statscache: more robust remove() ......................................................................
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/40439/6/vdsm/virt/sampling.py File vdsm/virt/sampling.py:
Line 426: """ Line 427: with self._lock: Line 428: ts = self._vm_last_timestamp.pop(vmid, None) Line 429: Line 430: if ts is None: I'd prefer to follow my religion of catching it in the highest possible point - on releaseVM(). Line 431: self._log.warn('timestamp for vm %s already removed', vmid) Line 432: return ts # for testing purposes. Should be ignored elsewhere. Line 433: Line 434: def get(self, vmid):