Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 5: (3 inline comments)
.................................................... File vdsm_reg/register-to-engine.py Line 59: """) % (name, name, name) How about:
"Usage: %(name)s" % {'name': name}
Line 93: for o,v in opts: Missing space after the comma.
Line 97: elif o in ("-p", "--port"): How did the space from the comma end up here? ;)
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com