Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 3: (2 inline comments)
Thanks for review.
I will add my self to the AUTHORS once I rewrite the whole bootstrap process... :)
.................................................... File vds_bootstrap/setup-2 Line 4: # Use is subject to license terms. OK. I will do this in a different patch.
.................................................... File vdsm_reg/deployUtil.py.in Line 60: _WORK_DIR = "/tmp" # hardcoded as server use it as-is As I wrote, this clearly violates FHS spec. The implication of missing /tmp is far greater than for RHEV, many application will not work.
Current implementation also reply on /tmp so nothing really changed.
I suggest to accept that as-is and if a requirement to use alternate location output files location is to be handled to do this in different patch.
Please keep in mind that in any case the engine uses SINGLE GLOBAL configuration, so if you have a single node which does not comply it forces to change the behaviour of all nodes.
The only real issue that can exist is /tmp mounted as noexec. In this case the output files can still go into /tmp and configure the server to extract the tarball at $HOME of root, this is supported by this patch.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server