Dan Kenigsberg has posted comments on this change.
Change subject: libvirtvm: Cast text to string when creating text node
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 541: self.dom.appendChild(self._devices)
Line 542:
Line 543: def appendChildWithText(self, childName, text):
Line 544: childNode = self.doc.createElement(childName)
Line 545: textNode = self.doc.createTextNode(str(text))
let's be nice to our Chinese and Hebrew contributors. Cast to unicode.
Line 546: childNode.appendChild(textNode)
Line 547: self.dom.appendChild(childNode)
Line 548:
Line 549: def appendConsole(self):
--
To view, visit
http://gerrit.ovirt.org/7832
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id22db83062eaf85645c2d61c83f3f20943918413
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel P. Berrange <berrange(a)redhat.com>