Petr Šebek has posted comments on this change.
Change subject: Avoid re-setting <boot> element when updating nic properties
......................................................................
Patch Set 1: Verified-1
When I tried to verify it there were this exception:
File "/usr/share/vdsm/vm.py", line 3093, in setLinkAndNetwork
vnicXML.firstChild.removeChild(vnicXML.getElementsByTagName('boot')[0])
File "/usr/lib64/python2.6/xml/dom/minidom.py", line 164, in removeChild
raise xml.dom.NotFoundErr()
NotFoundErr
After that I tried to change that piece of code to:
try:
vnicXML.firstChild.removeChild(vnicXML.getElementsByTagName('boot')[0]
except xml.dom.NotFoundErr:
pass
It fails with original exception:
libvirtError: this function is not supported by the connection driver: cannot modify
network device boot index setting
--
To view, visit
http://gerrit.ovirt.org/18796
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib81e1476e3ed31c9b07738cad1e45887f858d842
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Petr Šebek <psebek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No