Moti Asayag has posted comments on this change.
Change subject: BZ#811807 Enable network filtering ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 963: if hasattr(self, 'filters'): Line 964: for filterName in self.filters: Line 965: m = doc.createElement('filterref') Line 966: m.setAttribute('filter', filterName) Line 967: iface.appendChild(m) Indeed. The thought was to support list of filters per vnic in the API between engine-vdsm in order not to change this api in the future if libvirt will support multiple filters.
Since the entire patch-set series (except this one) relies on a single filter per nic, I'll modify engine-VDSM to support a single filter per vnic. Line 968: if hasattr(self, 'bootOrder'): Line 969: bootOrder = doc.createElement('boot') Line 970: bootOrder.setAttribute('order', self.bootOrder) Line 971: iface.appendChild(bootOrder)
-- To view, visit http://gerrit.ovirt.org/7353 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I33b3dc7021997f4d0c1194049b1c12ac3528f067 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server