Douglas Schilling Landgraf has posted comments on this change.
Change subject: [WIP] Adding flowID ......................................................................
Patch Set 2: (2 inline comments)
.................................................... File vdsm/clientIF.py Line 75: argsStr = str(args).split(",") humm, I remember it was a tuple instead of dict. /me going to check again. I just converted to str, then dict because it could safe time in the future if we need to change this code again. (Avoid to read each element of tuple every time we need it to locate the argument and then read +1 position to get the value, with dict it`s easy to manage such situation).
Line 100: logStr += " flowID [%s]" % argsDict['flowID'] I thought it was enough. Going to prepare a new version. thanks
-- To view, visit http://gerrit.ovirt.org/1221 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6c818d7a90fea41663fd48620ac9718451a8662f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com