Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-upgrade: use python scripts from ovirtnode ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm_reg/vdsm-upgrade Line 15: import logging.config Line 16: from time import strftime Line 17: from config import config Line 18: import deployUtil Line 19: from ovirtnode.install import * in many cultures, `import *` is considered rude. could you import only what you need? Line 20: Line 21: VDSM_REG_CONF_FILE = '/etc/vdsm-reg/vdsm-reg.conf' Line 22: VDSM_CONF_FILE = '/etc/vdsm/vdsm.conf' Line 23: log_filename = '/var/log/vdsm-reg/vds_bootstrap_upgrade.'+strftime("%Y%m%d_%H%M%S")+'.log'
Line 88: def doUpgrade(config): Line 89: fReturn = True Line 90: Line 91: install = Install() Line 92: if install.ovirt_boot_setup(): please make sure that exceptions are captured and logged by caller of doUpgrade() Line 93: msg = "<BSTRAP component='doUpgrade' status='OK' message='Upgrade Succeeded. Rebooting'/>" Line 94: print (msg) Line 95: logging.debug(msg) Line 96: else:
-- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Joey Boggs jboggs@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server