Nir Soffer has posted comments on this change.
Change subject: blockSD: do not try to parse metadata from missing pv ......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/27442/3/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py:
Line 670: pv = lvm.getPV(dev) Line 671: if not pv: Line 672: cls.log.warning("Could not get metadata from the device: %s", Line 673: dev) Line 674: continue
You return an incomplete mapping swallowing the error? Why is it legal to c
This is not incomplete mapping - this is the complete list of pv available at the time of the check. This may be different from the list that was available at line 651 - unless you lock lvm module for the duration of the iteration. Line 675: pvInfo = {} Line 676: pvInfo["guid"] = os.path.basename(pv.name) Line 677: pvInfo["uuid"] = pv.uuid Line 678: # this is another trick, it's not the