Nir Soffer has posted comments on this change.
Change subject: tests: Add initial FakeLVM tests and fix errors ......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/47857/3/tests/storagefakelibTests.py File tests/storagefakelibTests.py:
Line 92: Line 93: def test_vg_attributes(self): Line 94: expected = real_lvm.VG_ATTR(permission='w', resizeable='z', Line 95: exported='-', partial='-', Line 96: allocation='n', clustered='-') This is much nicer - I can both the type of the object, and the value of the attributes.
Can we convert the previous test to use the same style? Line 97: with self.base_config() as lvm: Line 98: vg = lvm.getVG(self.VG_NAME) Line 99: self.assertEqual(expected, vg.attr) Line 100: