Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Replace misused asserts with InvalidConfiguration ......................................................................
Patch Set 3: Code-Review-1
Nir, guys,
I don't think we need to correct this old code. Instead, we shall replace it when the time comes and not care about the checks here, they have become redundant.
getNicsVlanAndBondingForNetwork is only used in showNetwork and delNetwork to extract information from netinfo.NetInfo, in not a trivial way I might add.
getBondingForNic appears in objectivizeNetwork and Bond._objectivizeSlaves.
The bottom line here is that if something was broken in network configuration we would have already caught that when creating past networks.