Dan Kenigsberg has posted comments on this change.
Change subject: BZ#840594 Fix netinfo when libvirt bridge does not exist. ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm/netinfo.py Line 250: except OSError, e: Line 251: # If the bridge reported by libvirt does not exist anymore, do Line 252: # not report it, as this already assures that the bridge is not Line 253: # added d['networks'] Line 254: if e == errno.ENOENT: I'm pretty sure you have to
e.errno == errno.ENOENT
would you add a unit test for netinfo.get(), and this case specifically? Line 255: logging.info('An exception occurred while trying to get ' Line 256: 'information from a bridged network.', Line 257: exc_info=True) Line 258: continue
Line 251: # If the bridge reported by libvirt does not exist anymore, do Line 252: # not report it, as this already assures that the bridge is not Line 253: # added d['networks'] Line 254: if e == errno.ENOENT: Line 255: logging.info('An exception occurred while trying to get ' this is a bit of a long story: I prefer more informative strings such as
'obtaining info for net %s' Line 256: 'information from a bridged network.', Line 257: exc_info=True) Line 258: continue Line 259: else:
-- To view, visit http://gerrit.ovirt.org/7127 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2538a8ce2fafd8efed834b87b20a63d058afd96b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com