Nir Soffer has posted comments on this change.
Change subject: blockSD: raise an exception if missing physical volume ......................................................................
Patch Set 5:
(1 comment)
Nice, with more clear commit message this should be fine.
http://gerrit.ovirt.org/#/c/27442/5//COMMIT_MSG Commit Message:
Line 15: Line 16: This situation may happen as we cannot be sure that a given physical Line 17: volume will be accessible between the moment we first read the list of Line 18: physical volumes for a given volume group and the time we try to access Line 19: such physical volume's metadata. Since there is no special handling when reading the list of pvs and then getting the pv, the race in this operation is not interesting any more, so I think we can remove both of the paragraphs above.
Instead it would be better to describe the 3 places which are calling today lvm.getPV and how this patch effect them, as you described in reply to Federico. Line 20: Line 21: Change-Id: I9932b044c8b439dc8b1f09191a5d89f4bc44c38a Line 22: Bug-Url: https://bugzilla.redhat.com/1048696