Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 15: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm_reg/deployUtil.py.in Line 210: '/req_%s.conf' % random_num, Line 211: '/cert_%s.req' % random_num, Line 212: '/cert_%s.pem' % random_num, Line 213: '/CA_%s.pem' % random_num, Line 214: '/ovirt-id_rsa_%s' % random_num well, it works "by chance", since this is the last file you try to remove, and since the nasty code here silently ignores all exceptions.
most of the ugliness here is not due to you, I know. you can keep your little addition to this pile - I'll wait anxiously for your pending overhaul. Line 215: ): Line 216: os.unlink(_WORK_DIR + f) Line 217: except: Line 218: pass
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server