Mark Wu has posted comments on this change.
Change subject: BZ#848299 - Fix delete VLANed network with MTU=9000 ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/configNetwork.py Line 561: newmtu = None Line 562: for vlan in vlans: Line 563: if vlan == delvlan: Line 564: continue Line 565: cf = self.NET_CONF_PREF + delvlan Sorry, I still can't follow it. delvlan is the vlan under the network to be updated, while vlan represents each vlan created on the nic or bonding. This code is finding the biggest MTU, so it should read each vlan's configuration, not the current one, delvaln Line 566: mtu = self._getConfigValue(cf, 'MTU') Line 567: newmtu = max(newmtu, mtu) Line 568: Line 569: if newmtu != currmtu:
-- To view, visit http://gerrit.ovirt.org/7214 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I485c8bd3dfa84c421dab2c5d121ad7a5efc348a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server