Livnat Peer has posted comments on this change.
Change subject: Move createLibvirtNetwork and removeLibvirtNetwork to the ConfigWriter ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/netinfo.py Line 36: NET_CONF_BACK_DIR = constants.P_VDSM_LIB + 'netconfback/' I think that the name of the folder should not be specific to libvirt. We'll use it to backup logical networks info were we don't have config files, this info is used to restore the networks in libvirt. I would call it - 'logicalnetworks/'
-- To view, visit http://gerrit.ovirt.org/6893 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I672ce5fbe0c5db826d53664285ea6212f49fa50b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com