Gal Hammer has posted comments on this change.
Change subject: rest-api: Model VMs ......................................................................
Patch Set 6: I would prefer that you didn't submit this
(4 inline comments)
I didn't look at the code yet as I think that the REST api (as explained in the commit message) should be defined first.
.................................................... Commit Message Line 16: - Create a new VM and launch it It should be:
POST /api/vms
<data needed to create a vm>
Line 24: - Assign a connection password for the VM's display I would add a "action" (or something) to all the these paths:
/api/vms/<id>/action/ticket
Line 32: POST /api/vms/<id>/nics/add - Add a NIC POST /api/vms/<id>/disks
POST /api/vms/<id>/cdroms
POST /api/vms/<id>/nics
Line 41: all sub-collections inline. I don't think this is a deviation from the REST model. Since a creation of a VM requires all its hardware, you can't create a new VM resource unless you provide all the information.
After the VM was created and started, one can use the VM's URL and modify or query its hardware profile.
-- To view, visit http://gerrit.ovirt.org/3756 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibed650a0215e7d841f5af0dd5f111a3e4a27ecf1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com