Yaniv Bronhaim has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.5 ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/47941/1/init/vdsmd_init_common.sh.in File init/vdsmd_init_common.sh.in:
Line 261: ret=$? Line 262: elif grep -q '^vdsm-4.16.' "${upgraded_ver_file}"; then Line 263: # We need to treat the upgrade from 4.16.x specifically Line 264: # by running manual multipath configure command Line 265: "$VDSM_TOOL" configure --module multipath
if we can avoid restarting libvirtd, I think that we should.
mmm right ... iirc --force won't configure libvirt if its already configured. anyhow - without --force also multipath will not be configured if it runs Line 266: ret=$? Line 267: fi Line 268: [ "${ret}" -eq 0 ] && rm -f "${upgraded_ver_file}" Line 269: fi