Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 6: (1 inline comment)
.................................................... File vds_bootstrap/setup-2 Line 177: subprocess.Popen(execfn).communicate() 1. This is the current behaviour... nothing was changed in this regard.
2. stderr is caught by engine and logged, so we ok in this regard.
3. stdout is expected to be valid at engine side and expected to flow as command runs, so if we override it we need to pipe it though.
I suggest to consider this in future separately from this change.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server