From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: network: decode command output to native string ......................................................................
Patch Set 25:
(1 comment)
https://gerrit.ovirt.org/#/c/77724/25/lib/vdsm/network/cmd.py File lib/vdsm/network/cmd.py:
PS25, Line 62: 'utf-8'
aha i see now. i think we should provide kwarg for exec_sync that would ena
I think that adding an argument that changes the type of the output is a sad idea, which was one of the reasons we ran aware from vdsm's execCmd. I prefer adding another function for raw bytes, or as I said - add a TODO, a failing test, and ignore the issue until we really go py3.