Bala.FA has posted comments on this change.
Change subject: Added blkid tool support in supervdsm.
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/blkid.py
Line 48: blkIdDict = dict(map(lambda x: x.split('=', 1), out))
You are right. A device label can be any string including unicode. The default blkid
output does some translation. But we are using '-o udev' format which does
translation to hex for non-printing characters including '/' and white spaces.
Also '-o udev' format is udev/shell friendly.
These things were tested before submitting the patch. However I am going to send new
patch with the change you suggested.
--
To view, visit
http://gerrit.ovirt.org/2185
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9ad51df4f4b98e2aff5db1d9c02512045977a60
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>