Dan Kenigsberg has posted comments on this change.
Change subject: configNetwork: Ignore libvirt exception for network removing ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm/configNetwork.py Line 1232: delNetwork(network, force=True, It feels like, with the current availability of restoreNetworkBackps, we could avoid the networksAdded complexity completely.
note the "feels like" - I did not thing it through.
Line 1247: raise ex raising ex erases the stack trace. Why not have
else: raise raise raise
and get rid of "ex" completely?
-- To view, visit http://gerrit.ovirt.org/7062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ieb2044ddfa2cd4e194ad2315eceb9a815aa164fd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server