Martin Polednik has posted comments on this change.
Change subject: lib: grub2 module ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/47946/1/lib/vdsm/grub2.py File lib/vdsm/grub2.py:
Line 143: if not val: Line 144: continue Line 145: workarounds.append(val) Line 146: Line 147: return workarounds
could be a list comprehnsion
Not really, as split would introduce empty element. Line 148: Line 149: Line 150: def _add_workaround(workarounds, workaround): Line 151: try: