Dan Kenigsberg has posted comments on this change.
Change subject: rename xml.dom.minidom.parseString to _domParseStr in libvirtvm ......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 2290: getElementsByTagName('disk') thanks. there's always time for another, smarter patch.
-- To view, visit http://gerrit.ovirt.org/6847 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2e4ed0795b887c3df292eee1e2555428e1e9beae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server