Dan Kenigsberg has posted comments on this change.
Change subject: BZ#832765 - Load backups from backup files to memory
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(3 inline comments)
minor comments
....................................................
File vdsm/configNetwork.py
Line 318: if os.path.exists(loadDir):
it would be shorter to have
for fpath in glob.iglob(loadDir + '/*'):
Line 323: content = open(fpath).read()
I'd write
if content.startswith(self.DELETED_HEADER):
content = None
here, and only once.
Line 332: logging.info('Loading %s', fpath)
loading -> loaded
--
To view, visit
http://gerrit.ovirt.org/6967
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2003e1b0b198fd14d69cc0ed59b2e6d0d8abe36
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>