Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 1:
Doron,
I really don't understand.
master::VdsInstaller.java:
private static final String _remoteDirectory = "/tmp";
CONSTANT, not configurable.
No way it is working if TMPDIR is configure at node side.
I am not discussing theory, I am discussing current implementation. I promise that if I rewrite this I will explore the possibilities of different standards and FHS.
For now, the best solution is to hardcode it on bootstrap side to sync with engine.
FHS[1] states that /tmp is mandatory, so no issue here for now.
""" 3.17. /tmp : Temporary files 3.17.1. Purpose The /tmp directory must be made available for programs that require temporary files. Programs must not assume that any files or directories in /tmp are preserved between invocations of the program. """
[1] http://www.pathname.com/fhs/
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com