Dan Kenigsberg has posted comments on this change.
Change subject: ssl: m2crypto removal ......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/39990/3/tests/sslTests.py File tests/sslTests.py:
Line 369: "-key", self.keyfile, Line 370: ]) Line 371: self.assertEquals(rc, 0) Line 372: Line 373: @brokentest
This is the test that checks that sessions are cached, in order to avoid pe
The python-native implementation of ssl is unaware of ssl sessions, and it does not cache them.
However, since you introduced ssl session caching, the need for caching is much weaker, as we use long-living TCP connection, thanks to html1.1.
I admit the verification of this patch must make sure that there is no typical degradation of performance due to this patch. Piotr - are you aware if CPU consuption under load was tested?
Also please explain why the test is broken:
@brokentest('support for SSL sessions discontinued and may be reintroduced when we move to python 3')
https://docs.python.org/3/library/ssl.html#ssl-contexts Line 374: def testSessionIsCached(self): Line 375: """ Line 376: Verify that SSL the session identifier is preserved when Line 377: connecting two times without stopping the server.